-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carry triggerinstance context everywhere #1602
Comments
Little bit of a context of the use case which we talked about - Recently I added the ability to be able to filter executions by trigger instance id. This is useful when you know the trigger instance id or can look for it easily. For thousands of executions run in response to sensors listening to messaging queue such as rabbitmq, it is hard to find a particular execution. There a couple of ways to solve this -
Personally, I like option 1 better. This way, stackstorm doesn't need to communicate the id, since user already knows it. And this being an attribute of trigger instance, it makes it easy to filter by using stackstorm api or cli or even webui. If we use a custom attribute in payload to store this, users will need to explicitly pass it through all the actions in the workflow and filtering is harder as well. I believe this should be pretty easy to add as well. |
implemented with trace-tags |
on-start
notification to notify when an execution is startedActionTrigger_start
TriggerTypetriggerinstance.id
andtriggerinstance.correlation_id
should be available in notifier, actiontrigger etc.The text was updated successfully, but these errors were encountered: