Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST2 v3.3dev] Figure out if we can use the OS provided bats package or not #434

Open
blag opened this issue Apr 24, 2020 · 0 comments
Open
Labels
help wanted OS support Support/issues/PRs on a specific OS question

Comments

@blag
Copy link
Contributor

blag commented Apr 24, 2020

Context: #428 (review)

In actions/setup_e2e_tests.sh, we install BATS from GitHub:

if [[ -n "$RHTEST" ]]; then
    ...
    # Install from GitHub
    # RHEL 7+ has both bats and jq package, so we don't need to do this once we
    # drop RHEL 6 support
    git clone --branch add_per_test_timing_information --depth 1 https:/Kami/bats-core.git
    (cd bats-core; sudo ./install.sh /usr/local)
elif [[ -n "$DEBTEST" ]]; then
    ...
    # Install from GitHub
    git clone https:/bats-core/bats-core.git
    (cd bats-core; sudo ./install.sh /usr/local)

As of this writing, the current release on GitHub is version v1.1.0.

However, if they are suitably up-to-date, we might be able to simply use the bats package provided by Ubuntu 16.04+. This would also afford us more control over our test environment by helping ensure that upgrades to upstream BATS master do not break our tests.

Further investigation needs to be done. A good time to do this, for both Ubuntu and RHEL OSes, will be once we drop RHEL 6 support, in version v3.3.

@blag blag added the OS support Support/issues/PRs on a specific OS label Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted OS support Support/issues/PRs on a specific OS question
Projects
None yet
Development

No branches or pull requests

1 participant