-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate and possibly remove pip+virtualenv from setup_e2e_tests.sh #454
Comments
On a first glance, it seems to be safe to remove it. I'll take another look over the long weekend and see if I find anything. What would be the things to verify and test, if we remove if and want to be sure that it didn't harm? I am not sure if I got the whole picture already. |
To test it, we would just:
If everything passes, then we don't need that code, we merge the st2cd branch on GitHub, and install the st2cd pack from If things break, we will have to investigate why and fix them (or just put the virtualenv back). |
The pip installation and virtualenv creation in
setup_e2e_tests.sh
might now be superfluous, see here for context (also copied down below).Wayyy back in the day we used RobotFramework to test ChatOps, but I ripped those out and replaced them with BATS tests, see:
And our current code runs the ChatOps tests using the virtualenv for the
chatops_tests
pack:So I think this entire pip+virtualenv is now superfluous and can be removed.
If I remember correctly, we don't use RobotFramework anywhere anymore, so this looks like some cruft that needs cleaning up.
setup_e2e_tests.sh
:We need to investigate whether or not we can simply remove that.
The text was updated successfully, but these errors were encountered: