Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

st2actionrunner reloads on adding a new pack #95

Open
kritikash18 opened this issue Nov 8, 2019 · 3 comments
Open

st2actionrunner reloads on adding a new pack #95

kritikash18 opened this issue Nov 8, 2019 · 3 comments
Labels
Milestone

Comments

@kritikash18
Copy link

Currently, I have tried installing some custom st2packs by baking them in a docker image following https:/StackStorm/st2packs-dockerfiles and it worked well. But everytime I add a new pack by updating the image, the st2actionrunner pod reloads. So if I want to be able to add packs on a regular basis, it will certainly affect the execution of the actions and workflows running at that moment. Is there another way to add packs without affecting the execution?

@arm4b
Copy link
Member

arm4b commented Nov 8, 2019

Originally reported in https://forum.stackstorm.com/t/stackstorm-ha-st2actionrunner-k8s-rescheduling-death-consequences/910/.

The mechanism of re-starting st2acrionrunner to pick up new packs is how the stackstorm-ha Helm chart deployment was designed and works via helm upgrades. The packs filesystem should be copied/shared via st2actionrunner container which happens on pre-init stage via sidecar containers.

There is however another edge case here which coming from the st2 core:

Yes indeed, sudden re-schedule or death of st2actionrunner leads to broken workflow execution, according to: StackStorm/st2#4716 Ideally if st2 core could tolerate such failures with action re-schedules.

@arm4b
Copy link
Member

arm4b commented Nov 8, 2019

I believe there are 2 possible ways to improve this story:
handle properly st2actionrunner failures/re-schedules in st2 core or re-architect stackstorm-ha.

This could be a future enhancement.

@arm4b arm4b added this to the post-GA milestone Nov 8, 2019
@arm4b arm4b added enhancement New feature or request status:under discussion labels Nov 8, 2019
@manisha-tanwar
Copy link
Contributor

Hi @kritikash18 , Did you find any alternative for this.
I tried installing new pack/modifying existing packs and everything actually impact running action/workflow and it is marked as 'Abandoned'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants