-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract RPC summaries from backend responses. #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the warning. Can you provide the commands I need to run to do the rebase? Any idea when it'll become stable so that a simple |
58c1470
to
4e642d3
Compare
I was suggesting an interactive rebase:
@qingling128 and I just agreed to freeze the current |
I'll wait for the rebase to review, apparently the DIFF shows changes that are not part of your changes. When you've done the rebase, make sure you do |
…imeSeries and CreateCollectdTimeSeries.
Done, thank you. I didn't see 8a2a4f8 though. |
This one seems ready for review. @bmoyles0117 @igorpeshansky |
Reviewing now, thanks for the ping @qingling128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, barring 2 small comments.
Submitting. Thanks, Bryan! |
Implemented CreateTimeSeriesSummary parser. A follow-up change will use this to produce metrics.