Cherry-pick more upstream fixes to support building against python 3.8 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Python 3.8 and onwards C extensions are no longer linked to libpython so in order to embed python within an application the --embed flag needs to be added to python3-config --libs. A fall back is provided as the command will error out on previous python versions. References: https://bugs.python.org/issue36721
Since Python 3.8 --embed flag needs to be provided to python-config to embed python. Reference: https://bugs.python.org/issue36721 This was partially addressed in collectd#3170 but only fixed building and not linking with python.
igorpeshansky
requested review from
a team and
qingling128
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sophieyfang
approved these changes
Jun 29, 2022
sophieyfang
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits were adapted to fit the separate Python 3 code from #201.
http://b/168508440