Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Default Form Styling #1640

Merged
merged 170 commits into from
Aug 1, 2024
Merged

Update Default Form Styling #1640

merged 170 commits into from
Aug 1, 2024

Conversation

shervElmi
Copy link
Contributor

@shervElmi shervElmi commented Apr 18, 2024

This PR updates and redesigns the default form fields styling.

QA URLs:

Frontend URL: https://qa.formidableforms.com/sherv/wp-admin/admin-ajax.php?action=frm_forms_preview&form=new-style-fields

Admin URL: https://qa.formidableforms.com/sherv/wp-admin/admin.php?page=formidable&frm_action=edit&id=71

Pro Version PR:

https:/Strategy11/formidable-pro/pull/5012

Testing Instructions:

  1. Go to WP Admin > Formidable > Forms.
  2. Create a new Form and add fields in the Output sections mentioned below.
  3. Verify that the updated design is applied correctly without any bugs.

Note: Make sure to tap the "Reset to Defaults" button to apply the new styles as shown below:

CleanShot 2024-05-23 at 14 09 15@2x

Output:

Input, Textarea Elements:

CleanShot 2024-05-23 at 18 46 52@2x
CleanShot 2024-05-23 at 18 59 29@2x

Select Element:

CleanShot 2024-05-23 at 18 55 51@2x

International Phone Element:

CleanShot 2024-05-23 at 18 58 06@2x

Checkbox Elements:

CleanShot 2024-05-23 at 19 06 41@2x
CleanShot 2024-05-23 at 19 08 29@2x

Radio Button Elements:

CleanShot 2024-05-23 at 19 10 07@2x

Button Elements:

CleanShot 2024-05-23 at 19 16 25@2x

File Upload Elements:

CleanShot 2024-05-23 at 19 23 02@2x
CleanShot 2024-05-23 at 19 23 36@2x
CleanShot 2024-05-23 at 19 24 02@2x

Calendar Element:

CleanShot 2024-05-23 at 19 26 06@2x

Slider (Range Input) Elements:

CleanShot 2024-05-23 at 19 30 52@2x

Stepper Elements:

CleanShot 2024-05-23 at 19 32 02@2x
CleanShot 2024-05-23 at 19 32 16@2x

Star Rating Element:

CleanShot 2024-05-23 at 19 35 00@2x

Section Elements:

CleanShot 2024-05-23 at 19 36 39@2x
CleanShot 2024-05-23 at 19 35 59@2x

Error State:

CleanShot 2024-05-23 at 19 00 37@2x

@Crabcyborg Crabcyborg changed the base branch from l10n_master to master July 26, 2024 19:42
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
css/custom_theme.css.php (1)

317-323: Inconsistent application of the important flag for CSS variables.

Ensure that the important flag is applied consistently to all instances of var(--text-color) and var(--field-font-size) in css/custom_theme.css.php.

  • Instances missing the important flag:
    • font-size: var(--field-font-size);
    • font-size: calc(0.85 * var(--field-font-size));
    • font-size: var(--field-font-size);
Analysis chain

Verify the usage of CSS variables for file input styles.

Ensure that the CSS variables are used correctly and the important flag is applied consistently.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage of CSS variables for file input styles.

# Test: Search for file input styles. Expect: Correct usage of CSS variables and important flag.
rg --type css 'var\(--text-color\)|var\(--field-font-size\)'

Length of output: 120


Script:

#!/bin/bash
# Description: Verify the usage of CSS variables for file input styles in css/custom_theme.css.php.

# Test: Search for file input styles in css/custom_theme.css.php. Expect: Correct usage of CSS variables and important flag.
rg 'var\(--text-color\)|var\(--field-font-size\)' css/custom_theme.css.php

Length of output: 818

@Crabcyborg Crabcyborg added this to the 6.11.3 milestone Jul 31, 2024
Copy link
Contributor

@Crabcyborg Crabcyborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the Lite changes all look good.

I have a few concerns though about some pro features. I left comments in https:/Strategy11/formidable-pro/pull/5012.

I plan to merge this for next release. But I'm going to wait until the Pro PR is ready to merge as well, just in case the pro updates take longer than expected.

Thanks @shervElmi @garretlaxton and @tuguirazvan!

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants