Stop using left outer join for meta query

[Crabcyborg]

Default inner joins are more efficient and we have no reason to do a left outer join in this case since we're querying by field key, so we expect the field row to exist.

I also added some comments to make this all easier to read/follow.

[coderabbitai]

Walkthrough

The changes introduce a new public static method get_entry_meta_by_field to the FrmEntryMeta class in the FrmEntryMeta.php file. This method allows for the retrieval of entry meta data based on either entry ID or field ID, with enhanced SQL query logic that utilizes an inner join for field key queries. The existing methods remain unchanged, and the overall structure of the class is preserved while expanding its functionality.

Changes

File Path	Change Summary
classes/models/FrmEntryMeta.php	Added method get_entry_meta_by_field($entry_id, $field_id) for retrieving entry meta data. Updated SQL query logic to use inner join for field key queries. Existing methods remain unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FrmEntryMeta
    participant Database

    User->>FrmEntryMeta: get_entry_meta_by_field(entry_id, field_id)
    FrmEntryMeta->>Database: Execute SQL query with inner join
    Database-->>FrmEntryMeta: Return entry meta data
    FrmEntryMeta-->>User: Provide entry meta data

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f5a6630 and 4c4dd3d.

📒 Files selected for processing (1)

• classes/models/FrmEntryMeta.php (2 hunks)

🧰 Additional context used

🔇 Additional comments (1)

classes/models/FrmEntryMeta.php (1)

232-236: Addition of get_entry_meta_by_field method is well-implemented.

The new method get_entry_meta_by_field enhances the class by providing a flexible way to retrieve entry meta data using either entry IDs or field keys. The implementation is clear, and the method is properly documented.