Syntax: Fix testcase scope completion #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue which causes wrong selectors to be suggested,
when typing following test cases:
// <-|
## <-|
Note: | denotes to the caret.
The reason is the caret's column being used to extract scope names
instead of the one from the calculated assertion range. The assertion's
column is the one of the first character of the comment punctuation.
before this commit:
</style>
## <- meta.tag.style.end.html entity.name.tag.style.html
with this commit:
</style>
## <- meta.tag.style.end.html punctuation.definition.tag.begin.html
deathaxe
force-pushed
the
pr/syntax/fix-testscope-completion
branch
from
baea0d8
to
9f47253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue which causes wrong selectors to be suggested, when typing following test cases:
Note:
|denotes the caret.The reason is the caret's column being used to extract scope names instead of the one from the calculated assertion range. The assertion's column is the one of the first character of the comment punctuation.
before this commit:
with this commit: