Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing settings hints #343

Merged
merged 3 commits into from
May 17, 2021
Merged

add missing settings hints #343

merged 3 commits into from
May 17, 2021

Conversation

jrappen
Copy link
Contributor

@jrappen jrappen commented Mar 26, 2021

No description provided.

@UltraInstinct05
Copy link
Contributor

@jrappen Can you also add gtk_enable_key_translation as well, while you are at it ? (Introduced in 4103)
Reference: sublimehq/sublime_text#4024 (comment)

@jrappen
Copy link
Contributor Author

jrappen commented May 12, 2021

@Ultra-Instinct-05 maybe you can add that in another PR while @FichteFoll merges this one, I deleted my fork and don't have time for this in the next couple of days

@FichteFoll
Copy link
Member

Thanks. Some of the wording is suboptimal, but it's obviously still better than not having them in. I'm also surprised I can still merge this despite the original branch being deleted.

@Ultra-Instinct-05 if you could make a follow-up PR, that would be much appreciated. I struggled to find the time to work on the next PD release over the past weeks and didn't get it done on this weekend either, but I'll try again next week.

@FichteFoll FichteFoll merged commit 3424d15 into SublimeText:master May 17, 2021
@FichteFoll FichteFoll added this to the 3.3.2 milestone May 17, 2021
@jrappen
Copy link
Contributor Author

jrappen commented May 17, 2021

@FichteFoll It's just 14 lines, you could've just closed this and written it yourself. Whatever works.

@FichteFoll
Copy link
Member

I could have, but I also could have gone to bed an hour ago. It's all about compromises. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants