Issue #SB-941 feat: user services dependency #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsbajaj72
suggested changes
Nov 29, 2017
gsbajaj72
suggested changes
Nov 30, 2017
| /** | ||
| * Class provides user object for user related services */ | ||
|
|
||
| class UserPayload { |
There was a problem hiding this comment.
It should be a user object. It is not a payload to anything. Please rename class and file accordingly.
|
|
||
| class UserPayload { | ||
| constructor({ | ||
| userId, |
| class UserPayload { | ||
| constructor({ | ||
| userId, | ||
| userName, |
| let user = new UserPayload(res.result.response) | ||
| resolve(user) | ||
| }).catch((error) => { | ||
| console.log(error) |
| }).catch((error) => { | ||
| console.log(error) | ||
| if (_.get(error, 'body.params.err') === 'USER_NOT_FOUND') { | ||
| reject('USER_NOT_FOUND') |
There was a problem hiding this comment.
We should return an instance of error class
….3' into release-1.3
….3' into release-1.3
rajeevsathish
pushed a commit
that referenced
this pull request
Aug 20, 2021
Issue #SB:26013 : pill click event issue fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.