Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow keys don't work on FF macOS #18

Closed
Sv443 opened this issue Jul 19, 2022 · 0 comments · Fixed by #9
Closed

Arrow keys don't work on FF macOS #18

Sv443 opened this issue Jul 19, 2022 · 0 comments · Fixed by #9
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Sv443
Copy link
Owner

Sv443 commented Jul 19, 2022

On Firefox in macOS, pressing arrow keys to skip forwards & backwards doesn't work and comes up with this error:

grafik

Update:

The problem comes from the window object being only limitedly available in userscripts. YTM needs certain properties that are unavailable regularly, thus unsafeWindow is required to dispatch the arrow key events correctly.
This problem also extends beyond just the "arrow key skip" feature and applies to a few other BetterYTM features.

In the current constellation I don't see a way for this to be a potential vulnerability, unless a malicious, non-vetted plugin or userscript is installed, so this is just how it's gonna have to be.
You may remove the @grant unsafeWindow line in the userscript header but note that all features that dispatch events might break and you will be unable to use any BetterYTM plugins.

@Sv443 Sv443 added the bug Something isn't working label Jul 19, 2022
@Sv443 Sv443 self-assigned this Jul 19, 2022
Sv443 added a commit that referenced this issue Aug 4, 2022
@Sv443 Sv443 mentioned this issue May 27, 2023
23 tasks
Sv443 added a commit that referenced this issue May 31, 2023
@Sv443 Sv443 added this to the v1.0.0 milestone Aug 29, 2023
@Sv443 Sv443 closed this as completed in 1faba9c Sep 19, 2023
@Sv443 Sv443 closed this as completed in #9 Sep 19, 2023
Sv443 added a commit that referenced this issue Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant