Define logo-file as parameter

[BigBadBassMan]

Hi,
since the logo is passed to the pdf generator separately (outside the template), it should be configurable by users, so it can be replaced with the actual businesses logo.

This PR introduces 2 parameters, one holding the bundle-path to the default logo, and a second one, which can be set by an .env var defaulting to the first path, if not set.
With this 2 step approach, this PR is fully backwards compatible.

In addition, the flex recipe would need an update along with the docs to reflect this changes.

[lchrusciel]

Hey @BigBadBassMan,

Thanks for your contribution and welcome to our community ;) Could you adjust your code to my suggestion?

[BigBadBassMan]

I have no idea why the travis tests failed, local tests succeeded. Anyway, I'd love to see this merged, if there are no more blockers from your side.

[lchrusciel]

Hey @BigBadBassMan, we cannot merge anything until the build is green. Someone has to take a look into the master build and fix it before we will be able to merge this PR.

[BigBadBassMan]

Hey @BigBadBassMan, we cannot merge anything until the build is green. Someone has to take a look into the master build and fix it before we will be able to merge this PR.

I understand, perhaps you could trigger a re-test on travis?
It seems to me that this may be a transient failure, since I didn't change a single line in the tests, and my local tests (specifically the ecs and phpspec tests) run fine. The failure seems not to be related to my changes.

[lchrusciel]

I've restarted the build. However, the master is failing one way or another: https://travis-ci.org/github/Sylius/InvoicingPlugin/builds/676556586

[BigBadBassMan]

Hi @lchrusciel , I'm finally back on this, would you care to have another look (and possibly accept ;-) ) my PR?

[GSadee]

Thanks, @BigBadBassMan! 🥇