Update console command definition to SF 4.4 standards

[diimpp]

Non-BC maintenance change.

1. While command was already lazy loaded via DI definition, I think it's a better practice to keep command name in class itself + removal of misuse of constructor call.
   https://symfony.com/doc/current/console/commands_as_services.html#lazy-loading
2. It's good practice to define parent::__construct() last. No practical difference for the current setup though.
   
   https://symfony.com/doc/4.4/console.html#configuring-the-command

On separate note, will you accept progress bar for this command? It will require to do something with Generators like that

// src/Cli/GenerateInvoicesCommand.php
$this->massInvoicesCreator->setGenerateResult(true);

foreach ($this->massInvoicesCreator->__invoke($orders) as $result) {
    $progressBar->advance();
}

// src/Creator/MassInvoicesCreator.php
     {   
         /** @var OrderInterface $order */
         foreach ($orders as $order) {
             try {
                 $this->invoiceCreator->__invoke($order->getNumber(), $this->dateTimeProvider->__invoke());
                 if (true === $this->generateResult) {
                     yield true;
                 }
             } catch (InvoiceAlreadyGenerated $exception) {
                 continue;
             }
         }
     }   

or let me know if there is standard practice on how to expose progress to console from other services.

[GSadee]

Thank you, Dmitri! 🥇