Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify usage of buses #221

Merged
merged 6 commits into from
May 19, 2021
Merged

unify usage of buses #221

merged 6 commits into from
May 19, 2021

Conversation

SirDomin
Copy link
Contributor

No description provided.

@SirDomin SirDomin requested a review from a team as a code owner May 10, 2021 11:28
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 4 times, most recently from 0af9252 to c626420 Compare May 10, 2021 11:46
GSadee
GSadee reviewed May 19, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing of buses should be mentioned in UPGRADE file

tests/Application/config/packages/messenger.yaml Outdated Show resolved Hide resolved
@SirDomin SirDomin force-pushed the sylius-bus-unification branch 2 times, most recently from 9cab2d9 to 81bc76e Compare May 19, 2021 07:41
@GSadee GSadee merged commit 576dfea into Sylius:master May 19, 2021
@GSadee
Copy link
Member

GSadee commented May 19, 2021

Thanks, @SirDomin! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@pamil pamil pamil approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SirDomin @GSadee @pamil @lchrusciel