Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Remove wrong return types #250

Merged
merged 1 commit into from
Sep 13, 2021
Merged

[Maintenance] Remove wrong return types #250

merged 1 commit into from
Sep 13, 2021

Conversation

lchrusciel
Copy link
Member

These ids were integers for years already

InvoicingPlugin/src/Resources/config/doctrine/InvoiceShopBillingData.orm.xml

Lines 10 to 12 in 93a4fa8

<id name="id" column="id" type="integer">
<generator strategy="AUTO" />
</id>

InvoicingPlugin/src/Resources/config/doctrine/LineItem.orm.xml

Lines 5 to 7 in 93a4fa8

<id name="id" column="id" type="integer">
<generator strategy="AUTO" />
</id>

InvoicingPlugin/src/Resources/config/doctrine/TaxItem.orm.xml

Lines 5 to 7 in 93a4fa8

<id name="id" column="id" type="integer">
<generator strategy="AUTO" />
</id>

@lchrusciel lchrusciel requested a review from a team as a code owner September 10, 2021 13:49
@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Sep 13, 2021
@GSadee GSadee merged commit 7e111f7 into Sylius:master Sep 13, 2021
@GSadee
Copy link
Member

GSadee commented Sep 13, 2021

Thanks, Łukasz! 🥇

@lchrusciel lchrusciel deleted the fix-class-attributes branch September 13, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lchrusciel @GSadee