fix: compare when name is the same but not variant

[Snowbaha]

When the name, price and tax are the same whereas the variant is not the same, it's merged. The fix compare the variant to be sure.

[GSadee]

@Snowbaha thank you for your contribution, can you rebase the PR with master and fix the build by adjusting failing PHPSpec to your changes?

[Snowbaha]

I am not the more confident with PHPSpec :(

[GSadee]

You need to adjust this spec: https:/Sylius/InvoicingPlugin/blob/master/spec/Entity/LineItemSpec.php#L94:L108 to use there a variant code that you've added to LineItem compare method, I encourage you to try 😃

[Snowbaha]

I tried, tell me if it is ok?

[GSadee]

I tried, tell me if it is ok?

Yup, it looks OK 😃 but... there is also a need to adjust it_merges_with_another_line_item method in this spec because of added checking variant's code

[Snowbaha]

it shoudl be ok! :)

[GSadee]

Thank you, Julien! 🎉