Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DependencyInjection] Move registering resources to prepend method #277

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Apr 22, 2022

Before this change, resources and their parameters were loaded too late and they cannot be used properly for example in a grid or state machine configuration.

@GSadee GSadee added Bug Confirmed bugs or bugfixes. Maintenance Configurations, READMEs, releases, etc. labels Apr 22, 2022
@GSadee GSadee requested a review from a team as a code owner April 22, 2022 10:06
@GSadee GSadee force-pushed the prepend-parameters-and-resources branch from 170819e to 0887444 Compare April 22, 2022 10:39
@GSadee GSadee changed the title [DependencyInjection] Move setting parameters and registering resources to prepend method [DependencyInjection] Move registering resources to prepend method Apr 22, 2022
@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Apr 22, 2022
@AdamKasp AdamKasp merged commit 32d02a7 into Sylius:master Apr 25, 2022
@AdamKasp
Copy link
Contributor

Thank you, Grzegorz! 🎉

@GSadee GSadee deleted the prepend-parameters-and-resources branch April 26, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants