[Enhancement] Refactor and deprecate Invoice repository class #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometee
force-pushed
the
deprecate-old-repository
branch
from
ac92058
to
c2be2c0
Compare
Prometee
force-pushed
the
deprecate-old-repository
branch
from
250d47a
to
76d3b81
Compare
GSadee
added a commit
that referenced
this pull request
Oct 22, 2020
GSadee
approved these changes
Oct 23, 2020
| @@ -1,3 +1,11 @@ | |||
| ### UPGRADE FROM 0.11.0 TO 0.11.1 | |||
There was a problem hiding this comment.
Suggested change
| ### UPGRADE FROM 0.11.0 TO 0.11.1 | |
| ### UPGRADE FROM 0.11.0 TO 0.12.0 |
| 1. The custom repository has been removed : | ||
|
|
||
| - removed the repository class `DoctrineInvoiceRepository` and replaced by `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepository` | ||
| - removed the related service `sylius_invoicing_plugin.custom_repository.invoice` use `sylius_invoicing_plugin.repository.invoice` instead |
There was a problem hiding this comment.
Suggested change
| - removed the related service `sylius_invoicing_plugin.custom_repository.invoice` use `sylius_invoicing_plugin.repository.invoice` instead | |
| - removed the related service `sylius_invoicing_plugin.custom_repository.invoice`, use `sylius_invoicing_plugin.repository.invoice` instead |
|
|
||
| - removed the repository class `DoctrineInvoiceRepository` and replaced by `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepository` | ||
| - removed the related service `sylius_invoicing_plugin.custom_repository.invoice` use `sylius_invoicing_plugin.repository.invoice` instead | ||
| - removed the related interface `InvoiceRepository` use `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepositoryInterface` instead |
There was a problem hiding this comment.
Suggested change
| - removed the related interface `InvoiceRepository` use `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepositoryInterface` instead | |
| - removed the related interface `Sylius\InvoicingPlugin\Repository\InvoiceRepository`, use `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepositoryInterface` instead |
|
|
||
| 1. The custom repository has been removed : | ||
|
|
||
| - removed the repository class `DoctrineInvoiceRepository` and replaced by `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepository` |
There was a problem hiding this comment.
Suggested change
| - removed the repository class `DoctrineInvoiceRepository` and replaced by `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepository` | |
| - removed the repository class `Sylius\InvoicingPlugin\Repository\DoctrineInvoiceRepository` and replaced by `Sylius\InvoicingPlugin\Doctrine\ORM\InvoiceRepository` |
|
Thanks, Francis! 🎉 |
This was referenced Oct 23, 2020
lchrusciel
added a commit
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual
Sylius\InvoicingPlugin\Repository\DoctrineInvoiceRepositoryhas been deprecated and a new class has been defined in thesrc/Doctrine/ORMfolder with a name following the entity name.The corresponding interface has been also deprecated and the new one is owning the only required method.
I propose this PR because the actual repository was not correctly used : it was an override of
sylius_invoicing_plugin.custom_repository.invoiceinstead of a default value in the resource plugin configuration.