Merge pull request kubeflow#9 from heluocs/feature/fix_clean_up_polic…

…y_20220124 compatible for the mpijob which not specify clean pod policy
Syulin7 · Jan 24, 2022 · 05bf745 · 05bf745
2 parents 2423bdc + 7b09303
commit 05bf745
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/controllers/mpi_job_controller.go b/pkg/controllers/mpi_job_controller.go
@@ -512,7 +512,12 @@ func allocateGPUs(mpiJob *kubeflow.MPIJob, gpusPerNode int, done bool) (workerRe
  }
 
  if done {
- if *mpiJob.Spec.CleanPodPolicy == kubeflow.CleanPodPolicyAll || *mpiJob.Spec.CleanPodPolicy == kubeflow.CleanPodPolicyRunning {
+ if mpiJob.Spec.CleanPodPolicy != nil {
+ if *mpiJob.Spec.CleanPodPolicy == kubeflow.CleanPodPolicyAll || *mpiJob.Spec.CleanPodPolicy == kubeflow.CleanPodPolicyRunning {
+ workerReplicas = 0
+ }
+ } else {
+ // compatible for the mpijob which not specify clean pod policy
  workerReplicas = 0
  }
  }