Latest release - errors in text editor

[shilpapatil]

Hi,

TGM-Plugin-Activation v 2.4.1
class-tgm-plugin-activation.php showing errors in code editor.
Please check if these are fine.

[GaryJones]

Any clue what it is complaining about? Obviously some of it is the urlencode() but specifically?

[shilpapatil]

As per code hinting, these are syntax error.
On code lines with -

• global object - $GLOBALS['tgmpa']::$instance
• urlencode() in array

[jrfnl]

@shilpapatil No PHP syntax errors there, probably syntax parser errors in the editor though.

[Jelena1]

This is what I get when try to install theme:
Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM in /home/.../class-tgm-plugin-activation.php on line 1140

[shilpapatil]

This is what I got in editor:

[AndonDesign]

What version of PHP are you guys running? The parse error "Parse error: syntax error, unexpected T_PAAMAYIM_NEKUDOTAYIM ..." referencing $GLOBALS['tgmpa']::$instance might be related to a version of PHP lower than PHP 5.3, I encountered similar error on PHP 5.2.17, I believe the lowest WP currently supports is PHP 5.2.4 (https://wordpress.org/about/requirements/)

[goodwinpress]

I have this problem too - T_PAAMAYIM_NEKUDOTAYIM in /home/.../class-tgm-plugin-activation.php on line 1140
PHP version is 5.2.17

[Jelena1]

it's 5.3.29 PHP version

[shilpapatil]

PHP 5.5.12

[jrfnl]

Duh.. of course... I can see the issue with PHP 5.2 and am currently working on a solution.

@shilpapatil are you sure you're running into this with PHP 5.5 ??? I've just ran lints on the file with both PHP 5.5.9 as well as 5.5.16 and passes with flying colours.

[jrfnl]

Ok, I send in PR #306 which should fix this. Testing appreciated.

[AndonDesign]

thanks for the effort @jrfnl. I just tested it on localhost PHP 5.4.16 and got this error:
Fatal error: Call to undefined function get_instance() in .../class-tgm-plugin-activation.php on line 1138
I hope this helps

[goodwinpress]

Thanks for improving, but there is the same error - get_instance() at 1138 (5.2.17)

[jrfnl]

Yeah, sorry about that. I seem to have had my head elsewhere. All fixed now with my latest commit.

[shilpapatil]

@jrfnl pardon my ignorance. My editor supports PHP 5.4
Seems like you can ignore my original post, as it is only me who getting those syntax errors :)

[shivapoudel]

@jrfnl can you link the commit?

[AndonDesign]

Error's gone (thanks) BUT now the link is gone from the menu and there are no notices if I use your latest commit from #306 (40f8a0d)

[jrfnl]

@AndonDesign Yup, I noticed that too, working on it.

[jrfnl]

Ok, fixed it - working fix in PR #309 which will probably be merged into develop soon. Testing still appreciated.

[goodwinpress]

Thank you!!!

[AndonDesign]

Not sure if related to latest commit (030bdcc) but now I'm getting the following error when attempting bulk install: Fatal error: Call to undefined method WP_Upgrader::construct() in .../class-tgm-plugin-activation.php on line 1859

[jrfnl]

@AndonDesign Thanks for paying attention, I obviously am not, keep making typos today ;-) PR #311 fixes this.

[AndonDesign]

works a treat now! thanks :)

[shilpapatil]

Seems like issue is resolved. Hope it is ok to close this thread.
Many Thanks.