-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow add_submenu_page for WordPress.org themes via Generator #794
Comments
@acosmin Ripping that out via the generator was done at the explicit request of the wp.org Theme team, so yes, if you now want to start allowing it, the generator will need to be updated. PRs welcome. |
Sure :) could you please point me to the Generator repo? |
I think I found it :) https:/TGMPA/TGM-Plugin-Activation/blob/gh-pages/js/tgmpa.js I'll take it for a spin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@jrfnl We've started allowing
add_menu_page
&add_submenu_page
in themes on wp.org and we've noticed thatparent_slug
uses onlyadd_theme_page
via TGMPA Generator. This piece of codeTGM-Plugin-Activation/class-tgm-plugin-activation.php
Lines 740 to 742 in 2d34264
Thank you!
The text was updated successfully, but these errors were encountered: