Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow add_submenu_page for WordPress.org themes via Generator #794

Open
acosmin opened this issue Aug 24, 2020 · 3 comments
Open

Allow add_submenu_page for WordPress.org themes via Generator #794

acosmin opened this issue Aug 24, 2020 · 3 comments

Comments

@acosmin
Copy link

acosmin commented Aug 24, 2020

@jrfnl We've started allowing add_menu_page & add_submenu_page in themes on wp.org and we've noticed that parent_slug uses only add_theme_page via TGMPA Generator. This piece of code

} else {
$this->page_hook = call_user_func( 'add_submenu_page', $args['parent_slug'], $args['page_title'], $args['menu_title'], $args['capability'], $args['menu_slug'], $args['function'] );
}
should be allowed now. I guess the Generator needs to be changed.

Thank you!

@jrfnl
Copy link
Contributor

jrfnl commented Aug 24, 2020

@acosmin Ripping that out via the generator was done at the explicit request of the wp.org Theme team, so yes, if you now want to start allowing it, the generator will need to be updated. PRs welcome.

@acosmin
Copy link
Author

acosmin commented Aug 24, 2020

Sure :) could you please point me to the Generator repo?

@acosmin
Copy link
Author

acosmin commented Aug 24, 2020

I think I found it :) https:/TGMPA/TGM-Plugin-Activation/blob/gh-pages/js/tgmpa.js I'll take it for a spin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants