Default WP_List_Table Styles Rule for UI Improvement #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivapoudel
changed the title
shivapoudel
changed the title
|
This Changes |
|
@GaryJones could you look for this PR. |
GaryJones
added a commit
that referenced
this pull request
Oct 30, 2014
Default WP_List_Table Styles Rule for UI Improvement
|
@thomasgriffin and @GaryJones can this be commited for master and othe 3.0.0 branch too ;) |
|
@shivapoudel It will definitely be included in the 3.0 branch, not to worry (not sure about master). |
|
Cool! When is the release date? |
|
@shivapoudel eh... when it's ready... ;-) |
|
It won't be in 2.4.1 but it will be in 2.5.0 |
jrfnl
added a commit
that referenced
this pull request
Apr 28, 2015
- retrieve most information we need from our `$plugins` array rather than pass it through URL or $_POST - properly sanitize and validate received information from URL or $_POST - leverage the use of the WP_filesystem API - show an appropriate error message if user tries to activate an already active plugin - deprecate the `TGMPA_List_Table::_get_plugin_data_from_name()` method which is no longer needed as we have access to the `TGM_Plugin_Activation::_get_plugin_data_from_name()` method - Fix unauthorized issue on bulk installs when not using direct file access caused by #227 - Only prepare some variables and update recently activated plugins option when we actually need to Also: - abstract the regexes which are used a number of times to class constants - combine multiple `isset()`'s if used within the same if statement - don't nest what doesn't need nesting - unset loop variables if the function doesn't return straight after
jrfnl
added a commit
that referenced
this pull request
May 3, 2015
Most significant changes: - added views: 'to install', 'update available', 'to activate' - simplified the `_gather_plugin_data()` method by abstracting parts of it to separate methods - reverted the change to the constructor arguments from PR #227 as that breaks things, instead overload the `get_table_classes()` method which archives the same effect as PR #227 intended - added 'version' column and a method to generate the output for it - made column to display dependent on the chosen view - abstracted the plugin row actions to a separate method - made the row actions always visible (was on hover), similar to the WP native plugins table - added upgrade notice information to a plugin row if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
TGMPA_List_Tableis hijacking and extendingWP_List_Tablewhich is private class and is Limited for core usage only. Similary, we are utilizing similar plural args ofWP_Plugins_List_Tabletoo. Means we are adding plugins page style rules directly from the core plugins page and our table<thead> and <tfoot>checkbox are not well managed as well as other css stuffs. Thus let's be smart and accept defaultWP_List_Tablestyles rather than Plugins Page.