[Develop] Prevent duplicate message showing #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite a few themes and plugins which don't have their settings pages under 'options-general' also use `settings_errors()` to display their notices to the user. This resulted in the TGMPA messages being shown twice on those pages. This PR fixes that. Related: https://core.trac.wordpress.org/ticket/31000
jrfnl
changed the title
|
Would you mind creating this pull request against the master branch? I've not done anything with the develop branch in a while. Indeed, I need to actually remove it as it doesn't quite make sense for this repo. |
jrfnl
changed the title
|
Needs a |
|
@GaryJones Thanks for the feedback, adjusted. Not sure what the next version nr will be though, so left it at |
GaryJones
added a commit
that referenced
this pull request
Feb 5, 2015
[Develop] Prevent duplicate message showing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few themes and plugins which don't have their settings pages under 'options-general' also use
settings_errors()to display their notices to the user.This resulted in the TGMPA messages being shown twice on those pages as reported in #237.
This PR fixes that.
Related: https://core.trac.wordpress.org/ticket/31000