Only flush the plugins cache, not *all* WP caches. #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will save a lot of overhead of other (page/metadata) caches having to be recreated because we flushed them. This function was introduced in WP 3.7, so requires upping the minimum requirement of TGMPA.
|
I'm fine with upping the minimum level. I don't think anyone (TGMPA or themes and plugins that use it) should be supporting that far back anyway. Now 4.2 is out, I'd rather say that 4.0 is the minimum. Leaving open until you're happy enough to add the reviewmerge label and milestone. |
|
I'm happy to merge it like this for the 2.5 release. I suggest we revisit if we still need the flushing at all when developing 3.0. |
GaryJones
added a commit
that referenced
this pull request
Apr 24, 2015
Only flush the plugins cache, not *all* WP caches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will save a lot of overhead of other (page/metadata) caches having to be recreated because we flushed them.
This function was introduced in WP 3.7, so requires upping the minimum requirement of TGMPA.
Alternatively - if we wouldn't want to up the minimum requirement yet -, we could wrap this in a
function_exists()if then else block.[Edit]
Looking into this further, we could also choose to remove the flush calls completely and just up the minimum requirements as a quick check shows that WP 3.7+ will flush the plugin cache already. This, however, would need to be thoroughly checked for all situations in which we flush the cache.