Abstract single plugin activation to seperate method #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| } else { | ||
| echo '<p>', esc_html( $this->strings['plugin_activated'] ), '</p>'; | ||
| if( $this->activate_single_plugin( $plugin_activate, $slug, true ) === true ) { |
- reverse function true/false logic - now more logical from a function point of view, but completely incomprehensible on the receiving end of the function. - darn yoda (Seriously, if you use strict checking - as I do -, why the heck would I need it ? makes code so much less readable...)
jrfnl
force-pushed
the
feature/abstract-single-plugin-activation
branch
from
84df8f9
to
9d3f66a
Compare
|
Updated & rebased |
GaryJones
added a commit
that referenced
this pull request
Apr 28, 2015
…ugin-activation Abstract single plugin activation to seperate method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.