Feature/fix travis scrutinizer issues #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some unused variables - Initialize variables which may otherwise not be available / default case for `switch()` - Better default value for `populate_file_path()` parameter - Error prevention: check that that slug is actually in use - Error prevention: make doubly sure the filesystem is available before using it in a location were we *should* have it as we initialized it ourselves earlier - Some spelling
| @@ -534,7 +534,9 @@ public function admin_init() { | |||
|
|
|||
| global $tab, $body_id; | |||
| $body_id = 'plugin-information'; | |||
| // @codingStandardsIgnoreStart | |||
There was a problem hiding this comment.
Why does this bit need to be ignored?
There was a problem hiding this comment.
This is an alternative way to get round that one issue where we were considering excluding the rule or lowering the severity.
Now the rule is still being used, just not for that one line.
GaryJones
added a commit
that referenced
this pull request
May 7, 2015
Feature/fix travis scrutinizer issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one actual bug, fixes the travis run issues and should also fix about half the Scrunitizer run issues.