Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory safety bug on IBM to IEEE conversion using Numba on MacOS #117

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

tasansal
Copy link
Collaborator

No description provided.

@tasansal tasansal added the bug Something isn't working label Oct 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #117 (8ae4bbf) into main (21f44ad) will increase coverage by 0.19%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   81.21%   81.41%   +0.19%     
==========================================
  Files          42       42              
  Lines        1565     1560       -5     
  Branches      200      198       -2     
==========================================
- Hits         1271     1270       -1     
+ Misses        260      256       -4     
  Partials       34       34              
Impacted Files Coverage Δ
src/mdio/segy/ebcdic.py 100.00% <ø> (ø)
src/mdio/segy/ibm_float.py 46.42% <18.51%> (+3.09%) ⬆️
tests/unit/test_ibm_ieee.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tasansal tasansal merged commit dd1c7ca into main Oct 25, 2022
@tasansal tasansal deleted the fix/numba_safety branch October 25, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants