Add QC for SEG-Y ingestion based on trace density. #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 84.27% 84.21% -0.07%
==========================================
Files 46 46
Lines 2016 2033 +17
Branches 325 328 +3
==========================================
+ Hits 1699 1712 +13
- Misses 281 284 +3
- Partials 36 37 +1
|
tasansal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will prevent possible OOM errors due to nonsensical indexing for segy ingestion. The error will provide the user with insight on the issue by returning information on the requested grid shape which should inform the user on why the ingestion is problematic. Th update will produce warnings if the total grid size is greater than two times the number of traces and raise an exception if the trace density on the proposed grid is less than 1%.