Update logic for finding first non-zero sample index in SEG-Y data #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method using sum() to get non-zero indexes in multidimensional segy data was replaced with the np.where() method. This new approach directly checks where in the data non-zero elements exist, which provides a more accurate result especially in cases of complex top mute.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #247 +/- ##
==========================================
- Coverage 84.27% 84.23% -0.05%
==========================================
Files 46 46
Lines 2016 2017 +1
Branches 325 325
==========================================
Hits 1699 1699
- Misses 281 282 +1
Partials 36 36
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
np.sum()based method to get non-zero indexes in multidimensional SEG-Y data was replaced with thenp.where()method. This new approach directly checks where in the data non-zero elements exist, which provides a more accurate result, especially in cases of complex top mute. The sum was underflowing to zero in some cases where the values were too small.