Refactor the CLI dynamic command resolution #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class now dynamically loads command logic from the given plugin_folder, replacing the previous implementation. The new approach uses importlib to load command modules, which should improve security and maintainability. The "commands" command has also been updated to use the new implementation.
The __main__.py file now better handles command execution by listing known safe-to-execute modules instead of ignoring certain modules. Additionally, the retrieval of the package version has been refactored to use a function. This provides more robust error handling by returning a default value if the package version can't be retrieved for any reason. Cleanup changes have also been made to __init__.py.
tasansal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic module resolution was making some CLI failures on CI/CD (not sure why).
However, this PR refactors the CLI plugin resolution with a much safer approach.
Changes
evalwithimportlibfor secure dynamic command module loading, better mitigating arbitrary code execution risks.pathlibfor more robust path handling, replacingos.pathand string manipulations.