Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Minor suggestions for paper.md #7

Closed
richford opened this issue Feb 7, 2023 · 0 comments · Fixed by #13
Closed

[Documentation] Minor suggestions for paper.md #7

richford opened this issue Feb 7, 2023 · 0 comments · Fixed by #13

Comments

@richford
Copy link

richford commented Feb 7, 2023

I have three minor suggestions for the JOSS paper documentation.

  • On this line in the paper, the phrase "resemblance to peristimulus time histogram PSTHs" was confusing to me (as someone who is not familiar with the initialism. Perhaps you could enclose the initialism in parentheses like "resemblance to peristimulus time histograms (PSTH)"
  • Also, the use of "peri-stimulus" vs "peristimulus" is inconsistent in the paper. Perhaps all instances of "peri-stimulus" could be changed to "peristimulus"
  • For the reference to Kubeflow in paper.bib, can you retrieve the swid from software heritage in order to have a long term id on the resource. This can be accomplished by changing the kubeflow entry to @softwareversion. The author, title, year, and url keys can stay the same. And then you'd add a version key with the swid link. For example, for the latest version, you would use
  version = {\href{https://archive.softwareheritage.org/swh:1:dir:9afaedf1ae583012a7d949100fee98e664376b02;origin=https:/kubeflow/kubeflow;visit=swh:1:snp:32b07a4defabcb9748b8682e741dcfa7dcd66b4b;anchor=swh:1:rev:29e74b13975e5f0729fd731b2df3fcd2beee5690}{swh:1:dir:9afaedf1ae583012a7d949100fee98e664376b02}}

This will link to the exact version of Kubeflow that you are referencing and I think it's a good fallback option since Kubeflow does not provide you with a DOI.

ref: JOSS review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant