[BUGFIX] Generate correct values for datetime type fields
#413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmack
approved these changes
Jul 5, 2023
The database generator does not use the DataHandler for all operation due to some performance considerations. That means, that special handlings included in DataHandler needs to be adopted - at least in a stripped down version. For example, the DataHandler contains value transformation for `type = datetime` when the `dbType` is one of following types: `datetime`, `time`, `timesec`. Until now, now records are created with this constellation. To be able to add such fields in the future, we need to mimic partly work done by the DataHandler for these type in record generation. Releases: main, 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The database generator does not use the DataHandler for
all operation due to some performance considerations.
That means, that special handlings included in DataHandler
needs to be adopted - at least in a stripped down version.
For example, the DataHandler contains value transformation
for
type = datetimewhen thedbTypeis one of followingtypes:
datetime,time,timesec.Until now, now records are created with this constellation.
To be able to add such fields in the future, we need to mimic
partly work done by the DataHandler for these type in record
generation.
Releases: main, 12