Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #533

Closed
elfring opened this issue Jul 28, 2018 · 2 comments
Closed

reserved identifier violation #533

elfring opened this issue Jul 28, 2018 · 2 comments

Comments

@elfring
Copy link

elfring commented Jul 28, 2018

I would like to point out that identifiers like “__FACEANALYSER_h_” and “__LANDMARK_DETECTOR_MODEL_h_” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@TadasBaltrusaitis
Copy link
Owner

Thanks for the recommendation!

TadasBaltrusaitis added a commit that referenced this issue Oct 6, 2018
@TadasBaltrusaitis
A number of changes to bring up master to version 2.0.6 (#581)
be9b577 
- Removed duplicated code and some C++ warnings
- Fixing snapshot function in HeadPoseLive (test on PC)
- C++ code cleanup (#533, #534)
- Adding a Visual Studio 2017 solution file
- Moving to C++ OpenCV convention (thanks @taoyudong)
- Storing models in additional locations (see wiki and scripts) #553
@RyanYANG52 RyanYANG52 mentioned this issue Oct 7, 2018
Merged
@elfring
Copy link
Author

elfring commented Nov 29, 2018

Thanks for your adjustment of affected include guards.

ratgen pushed a commit to ratgen/OpenFace that referenced this issue Jul 7, 2022
@TadasBaltrusaitis
A number of changes to bring up master to version 2.0.6 (TadasBaltrus…
c0df9ab 
…aitis#581)

- Removed duplicated code and some C++ warnings
- Fixing snapshot function in HeadPoseLive (test on PC)
- C++ code cleanup (TadasBaltrusaitis#533, TadasBaltrusaitis#534)
- Adding a Visual Studio 2017 solution file
- Moving to C++ OpenCV convention (thanks @taoyudong)
- Storing models in additional locations (see wiki and scripts) TadasBaltrusaitis#553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @TadasBaltrusaitis