Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Background Player Notification To Use The New Android Q [10] Model #2845

Closed
2 of 3 tasks
PeterHindes opened this issue Dec 6, 2019 · 6 comments · Fixed by #3178
Closed
2 of 3 tasks

Update Background Player Notification To Use The New Android Q [10] Model #2845

PeterHindes opened this issue Dec 6, 2019 · 6 comments · Fixed by #3178
Labels
device/software specific Issues that only happen on some devices or with some specific hardware/software discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@PeterHindes
Copy link
Contributor

PeterHindes commented Dec 6, 2019 •
edited
Loading

The Android Q media player notification is much improved over the current notification NewPipe uses. Allowing for seeking in the notification and some new animations. It might be time to update the notification.
@Stypox
Copy link
Member

Stypox commented Dec 9, 2019

Also see #1660

@Stypox Stypox added discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface device/software specific Issues that only happen on some devices or with some specific hardware/software labels Dec 11, 2019
@Stypox Stypox mentioned this issue Jan 10, 2020
Closed
@cool-student cool-student mentioned this issue Jan 13, 2020
Closed
@cool-student
Copy link
Contributor

@PeterHindes check out my work in progress test apk
#1660 (comment)

@PeterHindes
Copy link
Contributor Author

@cool-student Can you link me a pull request for that feature? I want to add it to a custom build for my use.

@cool-student
Copy link
Contributor

@PeterHindes I'm still working on this and my code is a bit messy so there is no PR at the moment, my current eta is Wednesday (march 4th) for a PR.

@PeterHindes
Copy link
Contributor Author

@cool-student Very cool. I guess pull request was the wrong word, do you have a repo online right now? I'm interested in the messy code ;P

@wb9688
Copy link
Contributor

wb9688 commented Feb 28, 2020

@cool-student: Just FYI: NewPipe is licensed under the GPL. The GPL requires you to provide the source code to anyone you've distributed a binary to within a reasonable time. I (or anyone else who downloaded one of your apk's) could sue you if you don't provide me the exact code you produced the apk's you've published from, though obviously I won't sue you. Next time it'd be smart to open a (draft) PR before you upload any apk's.

@cool-student cool-student mentioned this issue Mar 3, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
device/software specific Issues that only happen on some devices or with some specific hardware/software discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification Improvements cool-student/NewPipe
4 participants
@PeterHindes @Stypox @cool-student @wb9688