Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queuing Single Song From Playlist Queues Entire List #5677

Closed
4 tasks done
Zakkumaru opened this issue Feb 22, 2021 · 17 comments
Closed
4 tasks done

Queuing Single Song From Playlist Queues Entire List #5677

Zakkumaru opened this issue Feb 22, 2021 · 17 comments
Labels
bug Issue is related to a bug

Comments

@Zakkumaru
Copy link

Checklist

  • I am using the latest version - x.xx.x
  • I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
  • I have read the contribution guidelines given at https:/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
  • This issue contains only one bug. I will open one issue for every bug report I want to file.

First of all, it could be a feature but it doesn't seem like it should behave this way if there are other methods for accomplishing the same thing.

Steps to reproduce the bug

  1. Click the bookmarks / saved playlists tab
  2. Open a playlist
  3. Long-press a single song
  4. Play in background

Actual behaviour

Entire playlist queues in the Now Playing Queue

Expected behavior

If you're only long-pressing one song, only that one should queue / play in background, especially since there are already buttons that apply to the whole playlist

Again, maybe this was coded as a feature but it seems to me that intuitively that would not be the expected behavior, especially considering that it also displays information related to the song (ie: title) in the context menu.

@Zakkumaru Zakkumaru added the bug Issue is related to a bug label Feb 22, 2021
@SameenAhnaf
Copy link
Collaborator

I have already mentioned a similar issue #5670. So, I believe this is a duplicate.

In that issue, I talked about enqueueing the whole list. Users should be given the option to both enable or disable it.

@Zakkumaru
Copy link
Author

I have already mentioned a similar issue #5670. So, I believe this is a duplicate.

In that issue, I talked about enqueueing the whole list. Users should be given the option to both enable or disable it.

What you wrote there is confusing, and it's a feature request. I am mentioning a bug. Also, what you are requesting in that feature suggestion doesn't sound like what I am talking about.

@SameenAhnaf
Copy link
Collaborator

I have already mentioned a similar issue #5670. So, I believe this is a duplicate.
In that issue, I talked about enqueueing the whole list. Users should be given the option to both enable or disable it.

What you wrote there is confusing, and it's a feature request. I am mentioning a bug. Also, what you are requesting in that feature suggestion doesn't sound like what I am talking about.

Well, for your convenience, Newpipe actually did it willingly. However, users should have the option to enable or disable auto-queue. You wanted to disable auto-queueing the playlist. Well, that is what I mentioned in #5670. Read that issue carefully. Your demand can be covered by implementing that issue.

@Zakkumaru
Copy link
Author

I have already mentioned a similar issue #5670. So, I believe this is a duplicate.
In that issue, I talked about enqueueing the whole list. Users should be given the option to both enable or disable it.

What you wrote there is confusing, and it's a feature request. I am mentioning a bug. Also, what you are requesting in that feature suggestion doesn't sound like what I am talking about.

Well, for your convenience, Newpipe actually did it willingly. However, users should have the option to enable or disable auto-queue. You wanted to disable auto-queueing the playlist. Well, that is what I mentioned in #5670. Read that issue carefully. Your demand can be covered by implementing that issue.

Let's agree to disagree.

@SameenAhnaf
Copy link
Collaborator

I have already mentioned a similar issue #5670. So, I believe this is a duplicate.
In that issue, I talked about enqueueing the whole list. Users should be given the option to both enable or disable it.

What you wrote there is confusing, and it's a feature request. I am mentioning a bug. Also, what you are requesting in that feature suggestion doesn't sound like what I am talking about.

Well, for your convenience, Newpipe actually did it willingly. However, users should have the option to enable or disable auto-queue. You wanted to disable auto-queueing the playlist. Well, that is what I mentioned in #5670. Read that issue carefully. Your demand can be covered by implementing that issue.

Let's agree to disagree.

I know I blab too much. But my last reply might be actually worth of your attention.

Your wish: Stop queuing the whole playlist when a single song is enqeued.
My wish: An "Enqeue All" checkbox to select or deselect auto-queue.

Then, how are they the same?
Well, if you uncheck "Enqeue All" button of the playlist, the whole playlist won't be enqeued when you select a song for "Enqeue"

Some people may want to enqueue the whole playlist. But the first video might be different. They will check the checkbox.

That's how it works.

@SameenAhnaf
Copy link
Collaborator

I have mentioned an even better alternative in #5737.

Your wish: Queuing Single Song From Playlist Queues Entire List
My wish: Replace "Play All" button with "Enqeue Method" drop-down menu

Then, how are they the same?
Well, if you select "None" from "Enqeue Method" drop-down menu, then all videos of the playlist won't be enqeued. Only the selected video will get som

Some people may want to enqueue playlists differently. Other options are for them.

That's how it works.

@hagueyno1
Copy link

Hi,
I'd like to see this too, newpipe used to be able to enque any song from within any playlist but instead as mentioned only now plays the entire playlist instead so you need to physically skip forward to your preferred songs.
I have a screen record of me showing you with the feature you talk about about above on and off and it doesn't make any difference, I'll try post it along with this comment, hopefully you'll be able to bring back this feature as it's been gone a while now and I've used your app for as long as I can remember and you guys really put the effort in which is half the reason I never thought to say anything I just thought it might have had some bug the meant removing the feature, I can't thank you enough 👍
It won't let me attach the video file but if you email me I'll send it right over.

@Zakkumaru
Copy link
Author

@XiangRongLin Sorry for reaching out this way but I found no other way to contact the moderators. If you wouldn't mind, could you remove the issue hijacking attempt above? I'm getting real tired of this Sameen guy hijacking every issue thread.

@XiangRongLin
Copy link
Collaborator

@XiangRongLin Sorry for reaching out this way but I found no other way to contact the moderators. If you wouldn't mind, could you remove the issue hijacking attempt above? I'm getting real tired of this Sameen guy hijacking every issue thread.

@mhmdanas leaving it up to you. You do more issue triaging than me. I support Zakkumarus opinion as i find some of his comments useless too which gets annoying considering how much he posts.

@hagueyno1
Copy link

hagueyno1 commented Apr 9, 2021 via email

@Zakkumaru
Copy link
Author

Zakkumaru commented Apr 9, 2021

Sorry? I honestly didn't realise I'd wound ppl up, I'll stop sending in issues then and wait for a fix but it's incredibly annoying that you can't search for anything at all.

@hagueyno1
No, it wasn't directed at you, at all. I mentioned the person I was talking about so that I wouldn't offend you. I apologize for not being more clear. It's about someone else. I have no issues with you. :)

@hagueyno1
Copy link

hagueyno1 commented Apr 9, 2021 via email

@AnonymousSeal
Copy link

Yeah also there is a inconsistancy which is worth pointing out. This behaviour only works when you have a background queue. If you start a video in Pop-up or even by normally clicking on it, only one video gets enqueued. So argueing that this is intended or a feature seems somewhat strange to me.
Please fix this issue, because it makes listening to music so much harder. Thx :)

@SameenAhnaf
Copy link
Collaborator

@Stypox Duplicate of #2510

@triallax
Copy link
Contributor

@SameenAhnaf the issues seem to be totally opposite though? This one says that the whole playlist is queued, but #2510 says that only the chosen item is queued... Which is the actual behavior?

@SameenAhnaf
Copy link
Collaborator

@mhmdanas Oh, I totally skipped a part of description. I started using Newpipe after 0.18. So, I didn't understand the description. 😅

Now, when I do the same, the selected track also starts to play, but this time it is enqueued into local playlist alone, losing any relation to the YouTube playlist, from which it was started. And next track in the local queue is not my playlist's next track, but randomly suggested track.

Anyway, #5741 covers both issues up though. Now, it's upto you how to proceed.

@Stypox
Copy link
Member

Stypox commented Nov 13, 2021

Yes, closing in favour of #5741

@Stypox Stypox closed this as completed Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

7 participants