Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout changed after upgrade to v.0.25.0 from 6 to 4 thumbnails per row ! #9763

Closed
6 tasks done
intraxit opened this issue Feb 9, 2023 · 27 comments · Fixed by #9858
Closed
6 tasks done

Layout changed after upgrade to v.0.25.0 from 6 to 4 thumbnails per row ! #9763

intraxit opened this issue Feb 9, 2023 · 27 comments · Fixed by #9858
Labels
Android TV Issue is related to Android TV feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface tablet UI Issue is related to Tablet UIs

Comments

@intraxit
Copy link

intraxit commented Feb 9, 2023 •
edited
Loading

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.0

Steps to reproduce the bug

Upgrade tolatest version

Expected behavior

Keep layout as in v0.24.1.

Actual behavior

I cannot go back to v0.24.1
Uninstalling and installing v.0.24..1 is throwing an error !

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Andoid v5.1

Affected device model

Tablet 10.5 inch

Additional information

No response
@intraxit intraxit added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 9, 2023
@opusforlife2
Copy link
Collaborator

Could you share a pic for comparison?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 9, 2023
@intraxit

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 9, 2023
@opusforlife2

This comment was marked as resolved.

Sign in to view
@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 9, 2023
@intraxit

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 9, 2023
@intraxit
Copy link
Author

intraxit commented Feb 9, 2023

Screenshot_2023-02-09-18-32-03

@opusforlife2
Copy link
Collaborator

Affected device model
No response

You're supposed to fill this info out. You didn't mention anywhere that you're using a tablet.

@intraxit
Copy link
Author

intraxit commented Feb 9, 2023 via email •
edited
Loading

@opusforlife2
Copy link
Collaborator

More context: #9310 (comment)

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface Android TV Issue is related to Android TV tablet UI Issue is related to Tablet UIs and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 9, 2023
@intraxit

This comment was marked as off-topic.

Sign in to view
@opusforlife2

This comment was marked as off-topic.

Sign in to view
@intraxit

This comment was marked as off-topic.

Sign in to view
@intraxit

This comment was marked as off-topic.

Sign in to view
@intraxit intraxit changed the title Layout changed after upgrade to v.0.25.0 from 5 to 4 thumbnails per row ! Layout changed after upgrade to v.0.25.0 from 6 to 4 thumbnails per row ! Feb 9, 2023
@opusforlife2

This comment was marked as off-topic.

Sign in to view
@intraxit

This comment was marked as off-topic.

Sign in to view
@intraxit
Copy link
Author

intraxit commented Feb 9, 2023

Pls keep old layout (6 thumbnails per row) and small subscription icons for tablets in new version !

@opusforlife2
Copy link
Collaborator

It's being considered.

@n-buna404

This comment was marked as resolved.

Sign in to view
@intraxit

This comment was marked as resolved.

Sign in to view
@mahendranv mahendranv mentioned this issue Feb 11, 2023
Closed
6 tasks
@s2r
Copy link

s2r commented Feb 12, 2023

@mahendranv that was a bug and its closed... and this is still a pertinent issue, for a tv user bigger thumbnails is good or at least the option for that, but for a tablet user this is a horrible horrible layout, even basic youtube website has smaller thumbnails and is more compact and if the sidebar is closed i get 5 thumbnails per row, the old layout wasn't perfect but it was way more usable than 4 huge blurry thumbnails with lots of wasted space.

@mahendranv
Copy link
Contributor

@s2r I agree. Just pointed out that issue was a duplicate and this one has better description of the issue.

Given that Android's different form factors, a layout might look good in one while completely unusable in another.

Scalable approach would be leaving the number of columns to the user.

@realquink
Copy link

Hey everyone, thanks for your hard work. We love newpipe!

I am chiming in to say I have the same issue with 0.25.0. As soon as I upgraded my 1080 TV went from about 6 or so thumbnails per row to now 3. As you can see they are wayy too big now and I have to scroll so much more to view my content vs quick eye scan multiple rows.

Maybe allow us to choose how many we want per row? Or at least put it back to what was in previous versions. Thanks for reading.

screenshot

@Stypox Stypox mentioned this issue Feb 25, 2023
Merged
5 tasks
@Stypox
Copy link
Member

Stypox commented Feb 25, 2023

Is #9858 a good enough compromise? The thumbnails would still be bigger than in 0.24.1, but no so big as they are now.

@intraxit
Copy link
Author

intraxit commented Feb 25, 2023 via email

@Stypox
Copy link
Member

Stypox commented Feb 25, 2023

@intraxit please stop suggesting that. There is surely already an open issue proposing the same thing, and apparently nobody has implemented it yet, but we know it would be a good solution. What we are talking about here is just fixing the 0.25.0 regression.

@s2r
Copy link

s2r commented Feb 25, 2023

@Stypox if its just fixing the 0.25.0 regression, then no... #9858 does not fix it, is it a good compromise? In the sense that it will make me drop the issue? then sorry but also no.

@Stypox
Copy link
Member

Stypox commented Feb 25, 2023

See #9858 (comment). Let's use #3139 to track progress on custom column count.

@intraxit
Copy link
Author

intraxit commented Feb 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android TV Issue is related to Android TV feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface tablet UI Issue is related to Tablet UIs
Projects
No open projects
v0.25.1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce the size of thumbnails on big screens to fit more grid columns Stypox/NewPipe
7 participants
@s2r @mahendranv @intraxit @realquink @Stypox @opusforlife2 @n-buna404