Update user agent to Firefox ESR 128

[TobiGr]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Updates the user agent used by the downloader to retrieve files to a current version

Related PR

See TeamNewPipe/NewPipeExtractor#1192

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[wb9688]

Why still Windows 10? And did you take this string from an actual instance of Firefox 128 on Windows 10 or just changed the number?

[opusforlife2]

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

[wb9688]

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

What about adding it to our release process documentation?

[TobiGr]

Why still Windows 10? And did you take this string from an actual instance of Firefox 128 on Windows 10 or just changed the number?

I have seen both user agents with and without the architecture info. We could also change to

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0

In that case I'd update TeamNewPipe/NewPipeExtractor#1192 first to check whether this causes any problems.

Also, we completely skipped 2 ESR versions. Can there be a Github Action to update this automatically, or at least remind us?

What about adding it to our release process documentation?

I also thought about creating a workflow for that. But that should happen in the extractor because user agent changes should be checked there. I don't think that updating the UA should be part of the release process because a faulty UA could brake stuff.

[ale5000-git]

Wht not using the User-Agent of ESR build of Firefox for Linux?
They change more rarely and they are supported for long time so they can't be blocked.
Example: Mozilla/5.0 (Linux x86_64; rv:115.0) Gecko/20100101 Firefox/115.0

[TobiGr]

We are always using the ESR version. I should have specified this. The current ESR version is 128

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud