Fix seekbar preview crashes

[Thompson3142]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Added error handling for recycled bitmaps and fixed the issue for specific videos crashing when the preview bar was pulled to the end twice.
Bitmap.createBitmap allows itself to NOT copy the bitmap if it is identical to the one it got passed. Since the same object is passed for bitmaps where nothing is cut out, recycling this bitmap leaves it unusable for later use.
Reference: https://stackoverflow.com/a/23683075 (the first comment to that answer)

Fixes the following issue(s)

• Fixes App crashes when seeking to the end of a specific video #11461

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[Thompson3142]

Always happy to receive feedback on commenting style, extra logging, different solutions to the problem, or the PR itself :)

[Thompson3142]

Just to add some context to what happens in the linked issue:

1. The user skips to the end of the video by using the seekbar
2. Since there is only one bitmap remaining (in some videos with the right length) Bitmap.createBitmap does not change the source bitmap so it returns the instance of the source bitmap
3. The user skips to the beginning of the video, since the source image was passed it is recycled in the process
4. The user skips to the end of the video again, but the image that should create the preview was recycled -> crash

[TobiGr]

thanks

[Thompson3142]

Sorry for interupting but i just realized that i actually do not check if the bitmap needs to be copied 🤦. Copying without that is both unneccessary and could produce memory leaks if i understand bitmaps correctly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud