Improve playlist header layout: align with info items #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you mean exactly? |
|
This work Well on my phone, playlist button don't make crush |
@TobiGr the screenshot on the left (local playlist) has a oneline marquee title, while the one on the right (remote) has a 2-line ellipsized title. |
|
good catch! multi-line seems to be the better thing here. We should be consistent. |
|
@TobiGr done, updated screenshot and debug apk: app-debug.zip |
TobiGr
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR changes paddings and margins for elements in the header of local and remote playlists.
I noticed the title for local playlists has a different behaviour from that of remote ones, should I make it more consistent?The local playlist title is now consistent with the remote's one.Fixes the following issue(s)
Fixes #3937
Testing apk
app-debug.zip
Agreement