Fix ic_volume_up and ic_volume_off being black #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mhmdanas, Thanks alot |
triallax
added
bug
AudricV
previously approved these changes
Apr 13, 2021
|
Can you also take a look at #6052 (comment) |
|
@TobiGr yes, I also noticed that issue, but that icon already has |
|
Please don't merge this PR yet. I am also going to fix the issue @TobiGr mentioned. |
triallax
commented
Apr 13, 2021
| @@ -4,7 +4,7 @@ | |||
| android:viewportWidth="24.0" | |||
| android:viewportHeight="24.0"> | |||
| <path | |||
| android:fillColor="#FF000000" | |||
| android:fillColor="#FFFFFFFF" | |||
There was a problem hiding this comment.
This fixed the issue for me, but I have no idea if this is the correct way.
triallax
changed the title
Stypox
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
(Possibly) fix an issue where ic_volume_up is shown in black.
I could not reproduce the issue, so I am unable to confirm if my changes actually fix the problem. @AlexN1997 can you see if this PR fixes the problem?
Fixes the following issue(s)
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence