Update RxJava to 3.1.5. #9520
Merged
Update RxJava to 3.1.5. #9520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With that big a bump, I hope it magically fixes some bugs. |
The newer version does fix some bugs (though I'm not sure if they apply in NewPipe.) It does make use of functionality only available on API 21+, which should reduce power consumption: ReactiveX/RxJava#7293 |
TobiGr
approved these changes
Dec 25, 2022
|
Shouldn't you update RxAndroid to 3.0.2 as well (maybe in a separate PR)? |
Sure, but the changes aren't very major, and it seems active development is not happening, as it's pretty stable. |
Stypox
approved these changes
Jan 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This should reduce power consumption on mobile devices: Removes the purge thread in favour of standard ScheduledThreadPoolExecutor APIs ReactiveX/RxJava#7293
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence