Update NewPipeExtractor and properly linkify comments #9631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Description
and not aString
anymoreTextLinkifier
:DescriptionFragment
toTextLinkifier
TextLinkifier
to not contain the redundant "link" word already contained in "Linkifier"TextLinkifier
methods to be notified when the text has been set to theTextView
, needed to set ellipsis and movement method in commentsTextLinkifier
only needs stream url and service id to generate popup-timestamps and hashtags, and since comments only have that information and not a fullInfo
, now theTextLinkifier
methods take those two parameters instead of an `Info.getText()
does not return aSpannable
, but rather aSpanned
(even though inTextLinkifier
aSpannableBuilder
is used). This means that the text selection (i.e. the highlight that appears when tapping on links) can't be manually set by us as done before inCommentTextOnTouchListener
, unfortunately.LongPressLinkMovementMethod
needs to be implemented inCommentTextOnTouchListener
.Fixes the following issue(s)
It definitely fixes some problems with comments, but I couldn't find any related issue.
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence