Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Chapters" icon #9691

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Change "Chapters" icon #9691

merged 4 commits into from
Jan 20, 2023

Conversation

Marius1501
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Changed the chapter icon because it was too similiar to the queue icon

Before/After Screenshots/Screen Record

Before:
grafik

After:
grafik

Fixes the following issue(s)

Due diligence

@Marius1501 Marius1501 changed the title Chenged the chapter icon Changed the chapter icon Jan 16, 2023
@Stypox
Copy link
Member

Stypox commented Jan 19, 2023

For some reason it looks a bit off... Can you check if the proper XML tags have been used to make the icon centered?
Screenshot_20230119-173233_NewPipe_change_the_chapter_icon.png

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Stypox
Stypox approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me

@Stypox Stypox merged commit f2af168 into TeamNewPipe:dev Jan 20, 2023
@Marius1501 Marius1501 deleted the change_the_chapter_icon branch January 20, 2023 07:26
@Stypox Stypox mentioned this pull request Jan 22, 2023
Closed
3 tasks
@enessgokalp
Copy link

Please get the old one. It's more beautiful than the new one

@Stypox
Copy link
Member

Stypox commented Feb 10, 2023

Nope, that won't happen

@AudricV AudricV changed the title Changed the chapter icon Change "Chapters" icon Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahendranv mahendranv mahendranv left review comments

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap the chapter and queue icon
4 participants
@Marius1501 @Stypox @enessgokalp @mahendranv