[YouTube] Support live URLs #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
reviewed
Jan 28, 2023
...g/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeStreamLinkHandlerFactory.java
Outdated
Show resolved
Hide resolved
…mLinkHandlerFactory - Move license header at the top; - Use an unmodifiable set for the subpaths instead of a modifiable list; - Add missing Nonnull and Nullable annotations; - Improve exception messages.
…amLinkHandlerFactoryTest - Remove unused imports; - Replace wildcard imports by single class imports; - Suppress "HTTP links are not secured" warnings from IDEA IDEs; - Replace removed video jZViOEv90dI by an existing video, 9Dpqou5cI08 (the corresponding test has been of course renamed).
AudricV
force-pushed
the
yt_support-live-urls
branch
from
f571720
to
ba24976
Compare
TobiGr
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkHandlertests still pass with my non-breaking API changes, everything should work fine in the app./live/links from external apps, as the extractor update will be done in a separate PR.This pull request adds support for YouTube's live URLs, which are in the form
https://www.youtube.com/live/LIVE_ID, whereLIVE_IDis the video ID of the livestream. This behavior applies to past, planned and running livestreams.Note that these URLs are then transformed to
watchURLs in the address bar with the desktop client once the watch page has been loaded.I also added a test for these live URLs and did minor improvements to the files changed (see the commits for details).
This pull request is the extractor part of TeamNewPipe/NewPipe#9546.