Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[peertube] add feed url in channels #298

Merged
merged 2 commits into from
Mar 28, 2020
Merged

[peertube] add feed url in channels #298

merged 2 commits into from
Mar 28, 2020

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Mar 28, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api. no need

This will add the rss icon on peertube channels.
I haven't made feedextractor in this pr, because it's not faster (the original page is already small).

@TobiGr TobiGr added the peertube service, https://joinpeertube.org/ label Mar 28, 2020
@TobiGr
Copy link
Member

TobiGr commented Mar 28, 2020

Please change the tests (here and here) accordingly,

TobiGr
TobiGr approved these changes Mar 28, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TobiGr TobiGr merged commit 69e0624 into TeamNewPipe:dev Mar 28, 2020
@B0pol B0pol deleted the feed_peertube branch March 28, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
peertube service, https://joinpeertube.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B0pol @TobiGr