Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose extractor via api scope #361

Merged
merged 1 commit into from
Jun 27, 2020
Merged

expose extractor via api scope #361

merged 1 commit into from
Jun 27, 2020

Conversation

yausername
Copy link
Contributor

TobiGr
TobiGr approved these changes Jun 27, 2020
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiGr TobiGr added this to the 0.19.6 milestone Jun 27, 2020
@wb9688
Copy link
Contributor

wb9688 commented Jun 27, 2020

I think this change is good, however why are we currently able to call stuff in :extractor from e.g. NewPipe then?

@yausername
Copy link
Contributor Author

I think this change is good, however why are we currently able to call stuff in :extractor from e.g. NewPipe then?

That's because jitpack packages a super module which exposes the root module and all submodules.
You can see the difference here (notice the scope tag in dependencies)
the actual root module
the super module packaged by jitpack

So in short, it works if you use jitpack.

@TobiGr TobiGr merged commit f4ed7ce into TeamNewPipe:dev Jun 27, 2020
This was referenced Jul 11, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.6
Development

Successfully merging this pull request may close these issues.
3 participants
@yausername @wb9688 @TobiGr