feat(dialogs): Remove history hacks in dialog #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 189e0ed. |
pladaria
changed the title
|
Screenshot tests report ✔️ All passing |
pladaria
force-pushed
the
pladaria/WEB-1761_remove-history-hacks-from-dialogs
branch
from
bec779c
to
8830f25
Compare
marcoskolodny
approved these changes
Mar 11, 2024
|
weren't you experiencing some problem with our |
brtbrt
approved these changes
Mar 12, 2024
I guess my previous implementation had issues. I rewrote this from scratch and it works as expected :) |
atabel
approved these changes
Mar 13, 2024
pladaria
deleted the
pladaria/WEB-1761_remove-history-hacks-from-dialogs
branch
tuentisre
pushed a commit
that referenced
this pull request
Mar 13, 2024
# [14.46.0](v14.45.0...v14.46.0) (2024-03-13) ### Bug Fixes * **CSS:** prevent browser default behaviours when long pressing or dragging links ([#1045](#1045)) ([717343d](717343d)) * **HighlightedCard:** improve optional types of title and description, make one mandatory ([#1039](#1039)) ([a818ffa](a818ffa)) * **Logo:** old version of Tu logo ([#1036](#1036)) ([0dc09e2](0dc09e2)) * **Switch:** iOS background in dark mode ([#1037](#1037)) ([a77c42d](a77c42d)) ### Features * **dialogs:** Remove history hacks in dialog ([#1041](#1041)) ([2a48cb4](2a48cb4)) * **IconButton:** update internal usages in Mistica components ([#1044](#1044)) ([12bf970](12bf970)) * **Icons:** New vivo icons ([#1038](#1038)) ([d070a25](d070a25)) * **Input fields:** update iconButton in all fields ([#1042](#1042)) ([062c0bd](062c0bd)) * **Naked & Small Naked Card:** Inner padding right in card content ([#1040](#1040)) ([d97ea17](d97ea17)) * **Rows:** add icon button as control ([#1030](#1030)) ([4d47e8f](4d47e8f)) * **ToggleIconButton:** create component ([#1034](#1034)) ([f4b9c6e](f4b9c6e)) * **Video:** `stop` method. To stop video and show the poster (if available) ([#1035](#1035)) ([e21998f](e21998f))
|
🎉 This PR is included in version 14.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove history hacks from dialog components to avoid interfering with similar hacks in apps.
Verification of this branch against the webapp brach that enables related skipped tests:
https:/Telefonica/webapp/actions/runs/8232821830 (multiple successful runs)
TODO:
Discarded options:
<dialog>element. Discarded because it interferes with other elements with overlays (like selects or tooltips), fixing that would require a large refactor and the previous implementation cannot be removed because<dialog>is not supported before safari 15.4. Additionally, the Close Watcher with back seems to be broken in chrome (it works using ESC).