feat(Input fields): update iconButton in all fields #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoskolodny
commented
Mar 4, 2024
There was a problem hiding this comment.
This change is expected. The previous implementation was not using correct touchable area for these buttons
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit e8e7752. |
|
Screenshot tests report ✔️ All passing |
marcoskolodny
commented
Mar 4, 2024
There was a problem hiding this comment.
Expected change: the button's area has increased
atabel
approved these changes
Mar 5, 2024
pladaria
approved these changes
Mar 6, 2024
aweell
reviewed
Mar 7, 2024
aweell
approved these changes
Mar 8, 2024
yceballost
reviewed
Mar 8, 2024
| @@ -147,7 +150,8 @@ const TEXTS_DE: ThemeTexts = { | |||
|
|
|||
| const TEXTS_PT: ThemeTexts = { | |||
| expirationDatePlaceholder: 'MM/AA', | |||
| togglePasswordVisibilityLabel: 'Mostrar ou ocultar senha', | |||
| enablePasswordVisibility: 'mostrar senha', | |||
| disablePasswordVisibility: 'esconder a senha', | |||
| loading: 'Carregando', | |||
There was a problem hiding this comment.
@nazaretcaballo-CX can you check these texts? 🫶
yceballost
approved these changes
Mar 8, 2024
tuentisre
pushed a commit
that referenced
this pull request
Mar 13, 2024
# [14.46.0](v14.45.0...v14.46.0) (2024-03-13) ### Bug Fixes * **CSS:** prevent browser default behaviours when long pressing or dragging links ([#1045](#1045)) ([717343d](717343d)) * **HighlightedCard:** improve optional types of title and description, make one mandatory ([#1039](#1039)) ([a818ffa](a818ffa)) * **Logo:** old version of Tu logo ([#1036](#1036)) ([0dc09e2](0dc09e2)) * **Switch:** iOS background in dark mode ([#1037](#1037)) ([a77c42d](a77c42d)) ### Features * **dialogs:** Remove history hacks in dialog ([#1041](#1041)) ([2a48cb4](2a48cb4)) * **IconButton:** update internal usages in Mistica components ([#1044](#1044)) ([12bf970](12bf970)) * **Icons:** New vivo icons ([#1038](#1038)) ([d070a25](d070a25)) * **Input fields:** update iconButton in all fields ([#1042](#1042)) ([062c0bd](062c0bd)) * **Naked & Small Naked Card:** Inner padding right in card content ([#1040](#1040)) ([d97ea17](d97ea17)) * **Rows:** add icon button as control ([#1030](#1030)) ([4d47e8f](4d47e8f)) * **ToggleIconButton:** create component ([#1034](#1034)) ([f4b9c6e](f4b9c6e)) * **Video:** `stop` method. To stop video and show the poster (if available) ([#1035](#1035)) ([e21998f](e21998f))
|
🎉 This PR is included in version 14.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Link