feat(TextLink): accesibility improvements #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atabel
commented
Apr 8, 2024
src/theme.tsx
Outdated
| @@ -13,6 +13,7 @@ const TEXTS_ES = { | |||
| disablePasswordVisibility: 'Ocultar contraseña', | |||
| loading: 'Cargando', | |||
| linkOpensInNewTab: 'Se abre en ventana nueva', | |||
| linkOpensInCurrentPage: 'página actual', | |||
There was a problem hiding this comment.
waiting for real translations:
https://jira.tid.es/browse/LOC-1503
atabel
commented
Apr 8, 2024
| @@ -136,6 +136,7 @@ const RawTouchable = React.forwardRef<TouchableElement, Props>((props, ref) => { | |||
| const type = props.type ? props.type : 'button'; | |||
|
|
|||
| const openNewTab = !!props.href && !!props.newTab; | |||
| const openInCurrentPage = props.href?.startsWith('#'); | |||
There was a problem hiding this comment.
I think this check is enough, wdyt?
There was a problem hiding this comment.
I can't think of a counterexample
|
Size stats
|
|
Accessibility report ℹ️ You can run this locally by executing |
|
Deploy preview for mistica-web ready! ✅ Preview Built with commit 66db209. |
pladaria
reviewed
Apr 8, 2024
pladaria
reviewed
Apr 8, 2024
pladaria
approved these changes
Apr 8, 2024
marcoskolodny
approved these changes
Apr 8, 2024
Co-authored-by: Pedro Ladaria <[email protected]>
Co-authored-by: Pedro Ladaria <[email protected]>
aweell
approved these changes
Apr 8, 2024
|
🎉 This PR is included in version 15.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-1623